Refactor pyswice utilities #818
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes commenting the code, reshuffling the logic for some of the if statements and removing hardcoded values
schaubh
added
documentation
|
The Windows CI build is having issues with saving off and reading the file from the unit test script. Unix systems don't seem to have issues. Remains work in progress right now until this is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the code, add a unit test to ensure the read/write functionality are working. Code pulled from LASP fork written by Joao Vaz Carneiro and updated for main Basilisk repo.
Verification
Unit test passes
Documentation
Added release notes, updated pyswice documentation
Future work
None